Y
Hacker News
new
|
ask
|
show
|
jobs
by
unwind
408 days ago
Please don't use if:s to assign boolean literals, just do it:
const trump_tariff = priceIncrease > 1.0
also saves you from not initializing the variable in the default/other case. :)
5 comments
Upvoter33
408 days ago
This was just someone showing you what the "Amazon programmer" was doing, and hence a deep cut reference to the likelihood of it being poor quality code :)
link
TheSoftwareGuy
408 days ago
If you really wanted to look like Amazon codex you would write Java :)
link
maxvisser
408 days ago
I see I missed an opportunity to make it even funnier.
link
throwaway519
408 days ago
const
I feel you may underestimate how often they change.
link
grokkedit
408 days ago
not to mention the mix of snake_case & camelCase
link
Someone
408 days ago
In the original code,
trump_tariff
is a sticky value. If that’s intended/not intended, the above introduces/fixes a bug.
link
ImHereToVote
408 days ago
If statements are great because they are highly readable.
link