Hacker News new | ask | show | jobs
by spicypete 440 days ago
In the spirit of constructive feedback, I filed an issue for you: https://github.com/reteps/dockerfmt/issues/18

I fixed this in the 0.2.8 release https://github.com/reteps/dockerfmt/releases/tag/0.2.8.

Relevant reading about the `&&` normalization. https://pkg.go.dev/encoding/json#Marshal
1 comments
ltbarcly3 440 days ago
It's still wrong, and I don't know how I could explain it more completely:

  -ENTRYPOINT service ssh restart && bash
  +ENTRYPOINT ["service", "ssh", "restart", "&&", "bash"]
You should read and understand the documentation for the containerfile format before continuing. This isn't some quirk because i'm using &&, you are breaking almost every dockerfile that doesn't use the array syntax for ENTRYPOINT.
link