[dkarl]

Agreed. For readability, ignoring DRY, my hierarchy of preference is:

1. One reasonable line of code

2. Several lines of plain code

3. A function call, moving the implementation elsewhere

4. A gnarly one-liner

(The tough part about this is drawing the line between 1 & 4.)