[nigels-com]

I tend to be picky about code reviews. I'm aware that it causes friction and can come across as unreasonable. It works, we're done, right? Well it's likely to be my problem to maintain this code at some point in the future. Overly complicated? Unstated assumptions? Lack of test coverage? Fits well with nearby things? Solving a problem is fun but software engineering is more than just the fun parts.

[senkora]

+1. Back when I was interning at various places, the conclusion that I came to was that it almost never made sense to push back on changes, because the reality was that I would be gone in 3 months and the reviewer would be stuck with that code for years. Even if I disagreed on something, the right thing to do was to clearly state my reasoning and then change it to whatever they wanted.

[jamesfinlayson]

Ugh, had this argument recently, to my detriment.

Tests are great in theory said my manager, but if the new doesn't want to write them, why are you making such a fuss. Fast forward three weeks and new guy is gone.