Hacker News new | ask | show | jobs
by iknownthing 480 days ago
I'm curious, does it get triggered when a PR is opened or when it is merged? Because if it is when it is opened, updates to the PR could still get made which I assume would cause updates to the doc changes. Also, what if 2 PRs are opened at the same time? What if a PR is opened but never merged?
1 comments
prithvi2206 480 days ago
Great questions! It is possible to get Promptless to run only when PRs are merged, or when commits are made on `main`, but pretty much everyone wants the doc updates to be drafted when PRs are opened, because they'd like to review the doc updates in parallel (i.e. before it's actually released). If two PRs are created at the same time, Promptless will review them separately (and potentially create two docs PRs, if both have customer-facing impact).

Honestly, some of these workflow points are areas that we're probably going to adjust and add more configuration around. For example, some folks with very high commit velocity are asking for a "daily digest" docs PR from Promptless instead of individual docs PRs.

link
crooked-v 480 days ago
Why not have a flow that automatically adds/updates stuff to the PR itself?
link
prithvi2206 480 days ago
If you're asking about when there are new commits on the source code after a PR is opened, yes that's what happens! It just updates the existing docs branch.

If you're asking if Promptless should just add doc updates to the same PR as the code PR, that's definitely an option, but people tend to just want them separate both because it fits better with their workflows and it's less contingent on CI/CD processes, if that makes sense.

link