Hacker News new | ask | show | jobs
by csomar 542 days ago
> I also get a lot of comments on my MRs about minor issues like spacing or formatting which only my tech lead cares about. Unfortunately my manager considered this as a bad thing.

This is a problem with your manager. He should provide a pre-hook or a PR action that reformat on pushes. Sure, you can't have everyone using a different formatting convention, that would be insane (especially for diffs) but everyone should have his own formatting on his own IDE.

1 comments

I think what’s weird is the formatting isn’t even something I can control for. In the past few MRs my tech lead asked me to apply changes he made which when compared has zero difference .
That would likely be whitespace. Most diffs have an option to compare whitespace. Your lead probably has that enabled and wants you using spaces or tabs exclusively and not mixed.

Something that VS does nicely is tells you at the bottom right what the document is using (CRLF vs LF and tabs vs spaces). Not sure how many others have that, but it is really nice.