Hacker News new | ask | show | jobs
by bruce511 543 days ago
>> I also get a lot of comments on my MRs about minor issues like spacing or formatting which only my tech lead cares about. Unfortunately my manager considered this as a bad thing.

I'm not sure I can help you with your bigger questions, but this part is worth a comment.

When I started programming I measured results by "does it work". The cosmetics of the code, and indeed the UI in general weren't terribly important to me.

I came to understand that being fastidious about the code sent a signal about the quality if the code. I was showing that I cared about the details -and if I cared about those details I cared about the details of the problem I was actually working on.

Likewise, customers only saw my UI. If it was ugly, they assumed the program code was buggy. Clearly that's a false assumption, but it follows that if my UI is sloppy then my code is sloppy.

If you are getting bad feedback in your review, take it to heart and improve that part of your game. It may not be important to you but is important to others (and when you get to do code reviews in the future you'll likely understand why.)

No one is perfect. No one "keeps up" all the time. But mostly your manager wants to see you improving, adding value to the team. Which means playing by the team rules.

Good luck - I hope the situation improves for you.