|
|
|
|
|
|
by quietbritishjim
555 days ago
|
|
|
You haven't met anyone that has quality issues but doesn't realise it? Lucky you! Even if they do, mentioning that everyone is rejecting their code and asking why they think that is, when you know full well the answer, is classic passive aggression and more condescending than just stating the obvious situation (again, not saying it literally needs to be in the same breath like the sentence I quoted). |
|
|
That's not what "rollbacks" means. "Rollbacks" means other people accepted their code, let it get into production, and then an issue surfaced that forced the change to be rolled back, and this happened multiple times. So at a minimum, there have to be other people besides this particular coder who made mistakes, multiple times.
If other people rejected their code multiple times in code review, the problem wouldn't be "multiple rollbacks", it would be "multiple rejections in code review", and yes, in that situation you have a much better case for being up front about "quality issues in their code", since the process itself is working and highlighting that specific issue.
> you know full well the answer
If you are operating on the belief that only this particular report bears responsibility for "multiple rollbacks", then I think you do not "know full well the answer". You are ignoring the fact that other people had to let this poor quality code get into production in order to have rollbacks happen. You are also ignoring your own responsibility as a manager (as the sibling post to yours by cutemonster pointed out) to address issues like this before they result in multiple instances of a problem with production code (see my response to the sibling post I just mentioned).