Hacker News new | ask | show | jobs
by binary132 574 days ago
From what I understood Mike does not want to merge someone else’s implementation of a new ISA but would rather be sponsored and do it himself. Can’t be bothered to source this claim at the moment so feel free to treat it as “came to me in a dream” level authenticity until proven otherwise. Seems reasonable though, I would also be paranoid about merging a sensitive complicated JIT implementation from an unknown contributor.
2 comments
versteegen 574 days ago
He wrote something along those lines here [1], which was in reply to a completely different, prototype-quality RISC-V port attempt

> Is the sponsor prepared to sponsor the initial review and integration into the LuaJIT default code base by me?

> Is the sponsor prepared to sponsor the inevitable initial bug fixes and the extra effort for continued maintenance that a new architecture entails?

Also, I should have been clearer about the new GC I linked to: I have not seen Mike say anything about it, and I wouldn't be surprised in the least if he rejects it and (wishes to) write his own, because he's had his own plans for many years. It seems impossible to get anything past him without modification. (I think it's a pity to see someone send a PR with a highly informative commit message and he replaces the body with "Thanks to X. #987")

[1] https://github.com/LuaJIT/LuaJIT/issues/628#issuecomment-716...

link
mordnis 574 days ago
I was a part of the team that contributed a few of the ports actually. For example, you can take a look at vm_mips64.dasc file header for the contributor list.

Though, it is possible that he changed his mind after having to review thousands of lines of assembly written by 25 year olds. :)

link
versteegen 574 days ago
Kudos! Was it difficult to get it accepted? I've seen ports rejected.
link
mordnis 573 days ago
To be honest, I forgot because it was quite some time ago. But I don't think we had any difficulties in that regard. I do remember being quite worried that it will not be good enough. In the time I started working on it, Mike sent a brutal email to a person trying to do PPC64 port (https://www.freelists.org/post/luajit/PPC64le-port-status,1).
link
binary132 573 days ago
LOL, vicious! I don’t feel sorry for them though — I learned a lot by getting a few harsh corrections when I was a young lad trying to run with bigger dogs.
link