Hacker News new | ask | show | jobs
by PenisBanana 601 days ago
If you had seen the qbittorrent code . . . it's _awful_.

Pages long un-commented functions, single spaced, appearing most like the prison notebooks of a wrongly-incarcerated psychotic. No testing of any return values at all (in the small part - a few packed pages - of the code that I looked at).

There was some field and if it got a correct 3-char (instead of the usual correct 2-char) value, the program would crash or something a minute or so later (I forget). As I was paid to program C++ ~~once~~ twice about 20 years ago, and from a "why don't _you_ have a look at it" message from a maintainer (which was 100% fair-enough, I thought) I ran it in a debugger. I got to the wrong & correct value(s) being read in from the GUI . . . and started following it/them . . . and then . . . so now there a -1 being passed around, and now everything just carries on, for a while.

Eventually the wrong valued-run would crash in some somewhat remote function with a wrongly-incarcerated psychotic's error message.

one of the real qbittorrent programmers did, then, fix it next release. But any how ...