|
|
|
|
|
by keybored
617 days ago
|
|
> I don’t really care about the commits in the PR, just like no one cares about the commits that produced the patch in the email workflow. They do care. They go through the trouble of reviewing it so that the resulting commit[1] that lands in the upstream repository is good. [1] Presumably you don’t mean “they don’t care about the commit that produced the patch”… since the patch is just a transport format for the commit. |
|
Commits. Not everyone will care to clean up their local history just to produce a single patch. You can git diff it out.
EDIT:
I was using "patch" for diff so scratch the above comment. Even then, when using a forge, I'd rather use squash unless everyone clean up their commit history when producing a PR.