|
|
|
|
|
|
by chkaloon
645 days ago
|
|
|
Good code review method, but that doesn't address the anxiety aspect, which is real. I always tried to treat and see it as a teaching and learning exercise and not make it accusatory or negative. As a reviewer, see it as an opportunity to teach others in good code practices. As a reviewee, see it as an opportunity to learn, not as a slam on you personally. Doesn't solve it completely, but it helps. |
|
|
On the anxiety aspect, I think my point is that -- okay, exercises and workbooks can have their place, but the real way forward is to have a thorough understanding of the task at hand and provide your constructive criticism and help your team make their way.
If you need more context, ask questions. If you need to poke and prod to understand how the pieces fit together, then poke and prod. With all of that knowledge you can have a productive conversation about the proposed changes.
On the other hand, without all of that, then it is guaranteed to be anxiety inducing, since with your review, you are taking some amount of responsibility for a thing you may not sufficiently understand.