Hacker News new | ask | show | jobs
by laurentlb 731 days ago
I was also global approver.

Examples of global changes include:

- changes to Buildifier that require updating existing files

- rename/refactor a function used everywhere in the repository

- fix the existing code before turning a lint warning into an error

- fix code that will break with a compiler update

Anyone in the company can propose this kind of change. The proposal will be reviewed by a committee (to ensure the change is worthwhile, that are mechanisms to prevent regressions, etc.) and by a domain expert (the team that owns the area).

Global approvers are people who often deal with this kind of changes. They usually come from the language teams (e.g. I knew the specificities that come with global changes touching BUILD/Starlark files).