|
|
|
|
|
|
by Grimeton
748 days ago
|
|
|
- Wrong shebang (debatable). - Variables not quoted... (This is dangerous) - PACMAN_MIRRORLIST_URL should be set in environment and only be overwritten in the script if the environment doesn't contain it. - No test on the url if it is the right one. - pipefail not set (This is dangerous, too). Use a temp file, read it into an array and work with that. - Curl should use -f (debatable) |
|
|