[hopfenspergerj]

This is an example of bad code.

[cinntaile]

Maybe you can expand upon that. Now we have no way of knowing why you think it's bad code.

[radus]

Quick critique: module contains functions with many parameters, many branches, deep nesting, and multiple return points.

[isoprophlex]

those nested if - for - for - if loops are horrendously difficult to understand.

take the fn starting at line 387. they comment why they do certain imports, but this function is comparatively underdocumented. it's not easy to wrap my head around the control flow. some bits are nested about 6 levels too deep for comfort, there are too many positions from which it can return or raise, and the function is about 3x too long

really difficult to grok what is happening here.

[mixmastamyk]

It’s not horrible, but I found a few odd things, like f-strings w/o params, long cli options with underscores, non-pythonic if == 0, etc.

[mixmastamyk]

Also the main god function is incredibly long and nested, as others mentioned. Nested --> long lines --> black making a mess.