| > Is every single atomic commit reviewed by someone? When do they review each of those commits? How many commits typically go into a PR? 1) yes 2) when a PR is submitted 3) it can be a lot for a huge project-wide refactoring, but generally I would say 1 to 5 is typical and up to 20 is not strange. > So a reviewer finds the appropriate commit that their comment applies to, and then changes the actual commit itself? No, the author applies the requested change and force-pushes once he has gotten all the requested changes applied. > because you seem to have something figured out Thanks! But it's not me—it's how Linux has used git from the beginning, for example. In fact it's the only workflow that is used by projects that still use email instead of GitHub/Gitlab PRs, but (trading some old pain with new pain) it is possible to use it even with the latter. The harder part is marching the review comments to the new patch, which is actually pretty easy to do with emails. It's quite some work and there's some learning curve. But depending on the project it can be invaluable when debugging. It depends a lot on how much the code can be covered by tests, in particular. |