Hacker News new | ask | show | jobs
by bombcar 861 days ago
That's exactly what happens. At some point a PR gets too big and the only thing you can do is run the tests, try the functionality, and LGTMYOLO approve it.

You leave it open longer in hopes someone else will look at it, and maybe one or two people look at places they've had issues in the past, but it gets through and blows up spectacularly and those get fixed.

Anyone who says their development is not the above is probably confused or lying ;)

1 comments

I've participated in month-long reviews where nobody's time was wasted. That's extremely rare, mind you, but if you're accustomed to low-quality code and a "break shit fast" attitude, you might be inclined to mistake that for a universal rule of software development.

In fact, if you put quality first, the "only thing" you can do with a long PR is actually do the work. And the more accustomed you and your team become with actually doing work, the more productive you'll be.