Hacker News new | ask | show | jobs
by karmakaze 863 days ago
Large and small PRs aren't the only options.

For a large PR, I usually regroup my changes into smaller unit commits which can be reviewed commit by commit.

For an even larger (or more complex) PR, I'll make a set of stacked PRs which can be reviewed in pieces, each with a good description of what/why/how stuff is happening in that piece. Once all PRs have been approved, the lot of them can be deployed together.

I've at times had 3 PRs for a total of 3 line changes, because they were for a single table's schema migration picking new indexes and each had many factors to consider. The PR descriptions were of course much longer.