Hacker News new | ask | show | jobs
by danielovichdk 859 days ago
"I have found that teams who allow larger PR sizes without complaining about it can get a lot done a lot faster".

Sure.

How many times is the code touched after the PR has been merged is a better question.

Faster is not better. Better is not faster.

1 comments

Weirdly, what the article claims is that it's the ideal size because of speed. So they are trying to say it's faster, therefore it's better.

Which is in my view a very silly claim devoid of any context.

The article also claims it's the ideal size because it minimizes reverts and ends up with PRs getting more thoroughly reviewed (based on # of comments). I think that makes for a more compelling case.
Not unless we know what those changes are.

Guess what, all typo commit fixes are <50 lines and never get reverted.

I wish never, definitely have been burned by a thinko in a supposed "typo fix". But I'll give you "rarely".
Haha, that's a fair point. Cries in dynamic languages

I've definitely had code with typos consistently replicated due to auto completion, then had to fix it all later on, haha.