Hacker News new | ask | show | jobs
by erik_seaberg 870 days ago
Writing good commit messages is part of your job in the sense that no reviewer should be approving anything without them, knowing that you may or may not be available if it breaks next year at 3 AM.
1 comments
kaashif 870 days ago
I put that kind of thing in the pull request, since that's where the review happens. Every commit links back to a pull request, and people actually do refer back to it. Writing good documentation there is part of the job.

No-one's going to ALSO write commit messages that no-one will see.

link
wnoise 870 days ago
The git history will last longer than the platform hosting the PR.
link
erik_seaberg 870 days ago
Not only is “git log” always up, I can also skim it without opening a hundred browser tabs.
link
cozzyd 870 days ago
pull requests don't live in the repository (as far as I can tell...) and require you to use whatever online interface creates them.

Not sure whey e.g. Github Pull request merges don't include the entire pull request description in the merge commit message.

link