|
|
|
|
|
by whstl
940 days ago
|
|
> "They accidentally get left in because you miss them." In my experience, this kind of thing happens much more frequently with large PRs. If a PR is large enough, things will slip through the cracks. If there are too many change requests, even if they're sensible and make sense, things will slip through the cracks. If there's the need for multiple checks by the reviewer, even more things will slip through the cracks. Also, breaking up PRs in frontend vs backend is not the best idea. Build the feature iteratively if possible. EDIT: Since the grandparent is talking about reviewing by commit: if those are more reviewable, just use those as the way to separate PRs instead, maybe? |
|