|
|
|
|
|
by AlotOfReading
946 days ago
|
|
What's wrong with reviewees marking comments resolved? That allows anyone reading to see what issues are "open" or already addressed at a glance. Code review isn't adversarial, so it's not like the reviewee is closing comments to shove bad code through and they need approvals anyway. |
|
My pet peeve with bitbucket was that when doing code review, you couldn't send all comments and overall review in a batch, every single comment was received in real time by the author. Sometimes I would be still reviewing code when the author pushed fixes to comments I've made before and that still might need other changes. After 15 years they improved that 2 weeks ago. I'm glad it's better, but I hate it with a burning passion.