|
|
|
|
|
by ender341341
963 days ago
|
|
Doing a squish merge on the actual merge, at least on github doing a rebase mid-pr makes the PR act funny (comments point at non-existent revisions and such). When I was at amazon their internal PR tool handled them just fine so I would do them in that case. There's more nuance to the OPs comment along the lines of > Don't rebase on branches others are working on On a pr branch I usually at most expect others to pull and do a build to run it locally so I'm not very worried about wiping out changes. |
|