|
|
|
|
|
by jaggederest
968 days ago
|
|
In this kind of context, I ask people what log level they'd like their review at. If you just want to get the code out the door, by all means, "error" or "warn" might be the right review depth, when you're confident in your code and don't want to be derailed with philosophy. If you're exploring a new concept and want all the ideas and brainstorming you can get in your feedback, "debug" log level is appropriate. Once that idea has moved down the pipe, you may be down to "info" or "warn" depending on how much conversation has happened around the PR. |
|