Hacker News new | ask | show | jobs
by jaggederest 968 days ago
In this kind of context, I ask people what log level they'd like their review at. If you just want to get the code out the door, by all means, "error" or "warn" might be the right review depth, when you're confident in your code and don't want to be derailed with philosophy.

If you're exploring a new concept and want all the ideas and brainstorming you can get in your feedback, "debug" log level is appropriate.

Once that idea has moved down the pipe, you may be down to "info" or "warn" depending on how much conversation has happened around the PR.

2 comments

This is a really useful analogy, thank you for sharing it.
> In this kind of context, I ask people what log level they'd like their review at.

It's a code review, not a QA session.

Isn’t QA the whole point of code review?
Code review is part of the QA but code review is code review. Tell me everything what you see, don't selectively skip things.