Hacker News new | ask | show | jobs
by dijksterhuis 962 days ago
I’ve made comments that start like that and it’s usually down to

1) obvious code smell, here’s an example using your existing code refactored and the reasons why it is a better fit here

2) you’ve done something I didn’t think of and it’s clearly better than the way I was thinking of it. Here’s why it’s better. Kudos!

Helps that I’m lead/principal in a small biz with like 4 people max writing code. So I kind of know what everyone is working on / what they’re touching with their changes.

Mileage will definitely vary in bigger teams / businesses. 100% helps that my performance isn’t tied to number of PRs reviewed etc.