Hacker News new | ask | show | jobs
by JoeMayoBot 979 days ago
Generally, reviews should be helpful and move the project forward. Sometimes a discussion is required because disagreements do occur. The appropriate way to handle it is to respond to the comment, explaining your case (rationally and without emotion), allowing the record to reflect the result of the discussion. This is important because it sets a standard and minimizes the opportunity for someone to jerk you around later because the standard was set in an earlier discussion.

That said, it's important to pick your battles and be right on issues that are important to you. I've worked on a lot of different projects. The people who set up the project pick the standards and sometimes that's me. If I arrive on the project later, I typically take the stand of "When in Rome...". Watching the existing team's standards and adapting to that is a good approach most of the time because I'm doing my part to moving the team forward with consistency - and you'll often hear about the value of consistency.

Often, no one is wrong on these things and you just disagree. If you lose, disagree and commit. However, by having these discussions in a healthy way helps you and other learn and can be fun.