[thdc]

Arguably it's less direct due to the superlatives and exclamations. For example:

> Christ. That's literally the remap_file_pages() system call definition. No way in hell does "ON_BEHALF_OF_KERNEL" make any sense in this context.

This could be

> That's the remap_file_pages() system call definition. "ON_BEHALF_OF_KERNEL" does not make any sense in this context.

If someone I didn't know or was unfamiliar with gave me a review like this I'd frown, but since Torvalds is known for this then I'd shrug it off probably. It's a good, thorough review though.

[withinboredom]

The first is better, IMHO. No need to be so dry and boring in your second example. Also, in the first example, I know the reviewer is completely against my approach. I need some proper ammo to rebut with, or go back to the drawing board. In the second example, it could easily turn into a multi-day back-and-forth until one of us gives up.

[pests]

Ah yes, the best way to enforce technology decisions is by insults and hostility.

[withinboredom]

I reread it and didn’t see a single personal insult. Can you point them out?

[falcor84]

With Linux and git being probably the most widely adopted open source software projects ever, it would be a valid argument that Linus's approach is by historical proof "the best way".

[endisneigh]

This is a logical fallacy

[falcor84]

Which fallacy?

[endisneigh]

Selection bias

[endisneigh]

I couldn’t disagree more. It’s simply a fact that the needless superlatives are verbose and distract from the point.

[GrinningFool]

I suggest: "I disagree. The needless superlatives distract from the point."

It conveys the same message without needless verbosity.

[endisneigh]

True

[withinboredom]

Congrats!? It’d be better if you could explain why… so there could be a discussion.

[endisneigh]

You’ve already made the point, otherwise you would’ve said:

“Jesus Christ, if you could just explain why then we could have a fucking discussion, yeah?”

Intuitively you already understand the point I am making :)

[withinboredom]

I attack with laughter and sarcasm. Other people have different coping mechanisms. Mine just happens to be socially acceptable atm. It wasn’t always, such as in school where I was accused of not taking things seriously.

[mcpackieh]

His derisive "Congrats!?" would already be in violation of modern American corporate communication guidelines and policies. That sarcastic praise made me feel belittled. The exclamation mark made me feel threatened and unsafe. Failing to coddle me is aggression.

[jjice]

I agree with the final sentiment but I do think you gave a good example of a more direct response. That said, there's something charming about seeing Torvalds's attitude come out. People really care about Linux and it warms my heart to see some passion.

[jonathanyc]

And in spite of the superlatives and exclamations, the author still didn't seem to get the hint that they should maybe go back to the drawing board. See their post which Matt Wilcox is replying to.

I've worked in environments where it was considered a little mean even to use the "request changes" button in GitHub, but it worked because people (1) got the hint when you left comments suggesting changes and (2) would be careful to address all of your suggestions before requesting review again. But I've also worked in an environment where people would try to sneak changes past you and then argue with you when they were caught. I don't think I've ever sworn in a code review comment but these days I can understand where Linus Torvalds is coming from. Things would be much nicer if people got hints and were careful, but we don't live in that world.

My friend tried to use a credit card in Japan, and instead of saying "no" the shopkeeper just bowed and said "excuse me." Meanwhile yesterday in San Francisco I saw a customer arguing with the cashier for five minutes at McDonalds about whether or not they could use a coupon twice.

[penguin_booze]

Admittedly, the first is what runs in my head if I were reviewing a patch that touches something with which I'm intimately familiar.

The second is how I'd consciously phrase it, because I myself prefer someone not tell me the first one.

Maybe Linus doesn't do second takes (and that's not a secret).