Hacker News new | ask | show | jobs
by frankreyes 998 days ago
> The developer could have accepted that allegedly inferior fix, give the credit, and patch it with their own version in a single commit.

My best oss contribution was done exactly like this. Someone else reviewed my code, made some changes, but my name was on the commits. I was happy that someone else took the time to make my code better and at the same time, keep my name on it.
1 comments
shkkmo 998 days ago
As has been mentioned elsewhere if this had been submitted via the standard process, something more like that might have happened.

However, this was submitted to the security mailing list which is optimized for quick, precise fixes, not for teaching new contributors how to adhere to coding standards.

link
FireBeyond 997 days ago
This methodology also has the side effect of "new contributor has security fix but can't contribute it because they need to be "taught" on non-security issues first."
link
shkkmo 997 days ago
No it doesn't.

The new contributor didn't have the knowledge and skills to make a patch that followed project standards. They were still able to submit a report and a first attempt at fixing the issue and get people who do know how to do that to craft a fix quickly. This is the system working correctly.

Rather than being thankful that other people contributed their time and effort to help OP solve the issue their company was facing, OP decided to misquote the person who helped them and start drama where none was needed.

link
FireBeyond 997 days ago
> Rather than being thankful that other people contributed their time and effort to help OP solve the issue their company was facing, OP decided to misquote the person who helped them and start drama where none was needed.

Wow, way to turn this around. The user had fixed their issue. Don't make it like "other people" "helped them solve it".

The user and his company were quite capable of compiling their own kernel and using that. They solved their own problem, with no help from others.

They then chose to disseminate it for the greater good.

And yet people like you are demanding that they show gratitude to the community for somehow deigning to help them.

link
shkkmo 997 days ago
You seem to take this very personally for some reason. I have "demanded" nothing...

Anyone is welcome to fork the kernel and commit code of whatever quality they want.

However, if they want their code included in the official kernel, then they need to follow that projects coding standards. They are not entitled to get their poorly written code merged to satisfy their ego.

Sure, a "suggested-by" tag would have been appropriate, but I would posit that after this public tantrum, getting assistance becoming official kernel contributor will be a bit harder. Who wants to donate their time and energy to someone who may twist their words to start unnecessary public drama as soon as they feel a little slighted?

link