|
|
|
|
|
by w0m
1025 days ago
|
|
A better way to describe it. Have you ever brought in a new engineer; and their first pull request gets a dozen or more 'Change this' 'this won't handle X'? Watch an NCGs face as the avalanche of (mostly minor, but still 'you did X wrong') PR comments come in. But if you're the reviewer - be sure to comment on nifty things in the code also. Call out that neat usage of struct as a switch or the context manager, or even praise base understanding of the problem flow. Mixing praise in with the (hopefully constructive) criticism can go a loooong way toward building a healthy team environment. And - Suprise! - you'll find you actually get invited to that beer lunch instead of always being bitched about at it. |
|