[packetlost]

Yeah, I agree. Passing in an optional `map[string]string` or something would be better, but then you get into having to either pass in `nil` every time you don't have the extra data or needing an entirely different function for with vs without the map

[masklinn]

> Passing in an optional `map[string]string` or something would be better

It would definitely not be better from the point of view of

> We wanted slog to be fast.

[packetlost]

A better interface/API is really what I meant. The performance characteristics are probably worth the tradeoff.

[returningfory2]

Passing in a map would require an extra allocation for the map memory for each log line. I think the performance would probably not be great?

[packetlost]

it depends. I believe map literals are stack allocated if they aren't shared across goroutines or globals.

[masklinn]

While the hmap struct can be stack allocated if it does not escape, I’m pretty sure the buckets still need to be heap-allocated. I do not believe hmap has a “flat structure” variant which could live entirely on the stack, though I could be wrong.

[Ferret7446]

It's most definitely not. Logging is crucial for monitoring services, and making logging statements many times slower will either sink your service or push developers to avoid logging and making the service impossible to debug.

Most log metadata will be attached by libraries and middleware, so service/application devs won't even see most of it.

[packetlost]

I think you interpreted my comment the wrong way, I think the performance tradeoffs are worth the mediocre API design. My bad for making it ambiguous