Hacker News new | ask | show | jobs
by bobthepanda 1043 days ago
Yeah, a good review must explain why, and should ideally explain how it should be instead if it needs explaining.

* This code should be changed looks bad - not a good comment

* This code should be chabged because ten nested ternaries gets hard to read - better

* This code is hard to read because there are ten nested ternaries. Can we replace it with a helper method that returns one value using if blocks? - best, in terms of actionability