|
|
|
|
|
|
by ar_lan
1042 days ago
|
|
|
I agree the onus is to establish a clear culture, guidelines, and mentorship to newbies and junior developers in this regard. Almost everybody who started their career probably had their first code review torn to shreds. I'm not saying that's the right way to do it. But I will say, just like when a junior developer comes in thinking "well it works, so it's right", there are almost always other considerations than just the happy path. A many-file, massive review might be 100% technically correct and flawless, and it's still going to take reviewers a lot longer to review than if they split it into 2-3. -- > Merging side branch into side branch is a valid strategy Completely agree! This is a fantastic strategy. You're not affecting the main branch, and generally people reviewing that specific branch can have the context of what your change is doing. |
|
|