|
|
|
|
|
by BlargMcLarg
1051 days ago
|
|
>As an uninvited specific action recommendation: I've made it a habit to look through PR's (merged and unmerged) regularly. If you did this in an environment with undercapacity, with the exception of being a very well respected or lead dev, I'd eventually call you out for being a snake trying to set the tone of development with nothing better to do. I had a colleague do this and its obnoxious. Especially because >reinforce your culture of excellence is almost entirely subjective. |
|
One other bit that's probably worth mentioning is that I'm quick to point out when I've learnt something new from the PR in question. I guess I bundle that with "call out excellent solutions" - but it's a slightly different thing.
> is almost entirely subjective.
Of course. But even the regular discussion of what amounts to excellence helps move teams in that direction. What we're trying to get away from is "don't give a fuck if what they do works or is of merchantable quality" which exists in bucket-loads in giant corporations and I want my teams to have no part of it.