|
|
|
|
|
by harrygeez
1071 days ago
|
|
> What I’ve noticed is that the code quality from those backend devs is quite awful Without knowing which metrics you use to measure the code quality, my hunch says you are focusing on the wrong thing. I am a frontend engineer turned tech lead. I think we developers choose our focuses based on our personal inclinations and what we value, and usually what I would notice is people who choose frontend work have different inclinations from backend developers. What is awful code? Is it not formatted consistently or prettily? The variables are not named descriptively? The code is not split or structured nicely? I find that frontend developers tend to judge code on superficial values. In an organization especially an engineering focused one, people get acknowledgements by solving problems. Very often, teams can function well enough without their main frontend guy but would struggle without one let alone a few strong infra or backend engineer. That's just the reality. |
|
1. No unit tests. Integration tests broken weekly when external data source would change.
2. Hand rolled ORM resulting in inconsistent separation of concerns. Some controllers would use the ORM classes directly. Some would add layers of indirection. Some would make database calls directly in the indirection layers.
3. Database data model would "compress" dimensions to be clever. ex: the id field is a concatenation of a user supplied string + timestamp + some hard coded string prefix. In addition, there's multiple columns which represent similar concepts like "tenant", "customer", "team".
4. Several ongoing migrations created necessary but hard to understand backwards compatibility logic. Code breaks in strange ways when trying to add features because you have to remember there's 2^n different code paths.
5. No async code. Everything was a blocking call to the database resulting in unnecessarily slow api responses.
6. No indexes in the database to improve db perf
The managers didn't see this stuff. They just know features can take a while to get out the door so they respond by asking for more head count. Leadership sees that more backend devs are needed and hire more backend focused managers to try and manage the fact that there are scaling and perf issues.