Xbox has always had more comfortable controllers imo. This gen it’s closer because PlayStation finally copied the ergonomics from an Xbox controller.
I've always found the original Xbox/Xbox one controllers horribly oversized and heavy compared to the PlayStation 2 ones. The early PS1 controllers without analog sticks were a bit small but personally they've always seemed to have the best balance of weight, size, shape, stiffness, and quality.