Hacker News new | ask | show | jobs
by jorvi 1116 days ago
Could just fix the typo yourself and reference the PR in your commit then close the PR without pulling.

I imagine contributors won’t exactly be happy with that though.

1 comments

Honestly, who cares if the end result is the same? Their forked repo with the patch on still exists, the patch was incorporated in whatever way made sense to the original repo owner.

OK, a credit, but really, who cares? People can see what an accepted pull request consisted of, so I'm not sure they're kidding anybody in terms of boosting their reputation with credits for fixing typos.

All the same, I'm just glad to see people improve their presentation, especially typos.