| At my first job, I was on a small team and my boss did all the code reviews. He would leave comments like: - "This is really awkward, change it to..." - "This variable name is awkward and confusing" - "You have failed to understand..." - "You are overthinking this. Keep it simple and do..." - "This causes unnecessary overhead. Think about it..." Every review, I would have to re-write everything to exactly how he wanted it, variable names, logic and all. To the point that the code was not mine. I would very much disagree with what he wanted. Any type of constructive push back would be met with enormous backlash. But it wasn't always what he wanted me to change, - the way he delivered the feedback irritated me the most. In my following jobs, I have had many reviewers for my code. I've had 30+ other people review my code. They have all been much nicer. And deliver feedback that I actually agree with. I am thankful when someone finds a bug in my code, or an easier way to do something. Using a function that I am not aware of. This way QA won't find the bug, and I am learning. Anyways, my advice is to look at how the person is delivering the feedback. Take note of that, and know it is them if they are toxic. And when you do a code review for someone else, be sure not to be that person. |