Hacker News new | ask | show | jobs
by mdaniel 1179 days ago
Foremost, thanks for choosing a business friendly license. I know that statement is going to ruffle feathers, but I'm still grateful. I'm also grateful for you choosing postgresql

You will want to strongly consider pinning a node version since it's a huge list of possible values that can go there: https://github.com/reprohq/repro/blob/main/apps/api-server/D... (it certainly looks like `node:18` is the correct one based on https://github.com/reprohq/repro/blob/main/.tool-versions#L1 )

Also, please don't hard-code AWS credential configurations like this; if you're using the AWS sdk it automatically supports a wide range of credential discovery mechanisms, which certainly includes those famous env-vars, but by not hard-coding that it allows the server to work correctly in a lot more diverse configurations (EKS, IMDSv2, AWS_PROFILE, etc): https://github.com/reprohq/repro/blob/main/apps/api-server/s...