Hacker News new | ask | show | jobs
by eikenberry 1206 days ago
Yes. I'm saying that due to this relying on an external service it would be inappropriate for a pre-commit hook as you could only commit while online.
3 comments

> [...] it would be inappropriate for a pre-commit hook as you could only commit while online.

Why does that matter?

Hey, some of us live in caves.
Add the —no-verify flag when working out of your cave.
git commit --no-verify ?
If the developer wants to slow their own development workflow by delaying the code review, that’s.. concerning.
in what way is your comment pertaining to this thread?

If a user is offline, they are not going to be able to push code for review anyway. Either way, it seems prudent to shift validation and checks closer to the developer, before pushing code. Otherwise you end up with a series of commit & push, wait for check, commit & push fixes, wait for check, commit & push more fixes...

pre-push hook?