Hacker News new | ask | show | jobs
by kdazzle 1235 days ago
I’m with you. If I don’t think a chunk of code is readable, I’m not going to rewrite it all for them off the bat. I’ll just say that it’s not clear and could probably use some cleaning up. And they can either push back, or do something on their own, or ask if I have anything in mind, or seethe silently and ignore me. If it’s complicated or seems like they’re struggling then I’ll ask if they want to pair on a solution.

Otherwise it’s kind of like - “why didn’t you just do this yourself if you had something so specific in mind?”

1 comments

This works better if you both are in roughly the same time zone. It's not so great when you have to play "guess what the reviewer wants" with one day of latency between iterations of the review.
Your code reviews are doomed regardless if the feedback cycle is 1 day.