|
|
|
|
|
by doodlesdev
1249 days ago
|
|
I'm pretty sure they weren't because of the redundant conditionals which simply defy logic. If there was only one check for every if statement, honestly I could give this a pass since it's at the very least simple, but by adding one extra redundant check for every statement you just created 9 new places where a bug could appear. Furthermore, using Unicode characters to represent progress is the true smell here. There simply are better ways to do this. In the grand scheme of things, does it matter? No. But this is Hacker News LOL, someone has to discuss it. |
|
Sure, you can do it better, but why would you? There are other, more pressing issues in this code (that probably also don't warrant spending extra time on refactoring).
Those redundant checks are highlighted in every IDE I can think of. I can only assume they're there for readability.