Hacker News new | ask | show | jobs
by pai 1251 days ago
Both first and second links contained comments in JSON, which is invalid.

I have now added fix to strip the comments, it should work now.

The last link does not have bare minimum requirement of a background color, see FAQ point 4: https://nice.github.io/themeforge/faq/#happy-little-accident...

Thanks for reporting.
1 comments
suprjami 1251 days ago
Cool, thanks for the quick response!

Note the first link is the official VSC repo, nothing in there should fail. Can you automate testing of every theme shipped with Code? That would seem to be a good first step.

It might also be helpful to expand your error messages more. Your audience is developers here. Even if I'm not a JSON genius I can still read an error message and try to fix things myself.

link
pai 1251 days ago
Just because it is in the official VSC repo does not necessarily make it right, it is clearly an invalid JSON file and the error message is displayed.

Showing the exact line number of the error is beyond this project's scope for now.

I'm currently using https://www.npmjs.com/package/strip-json-comments to remove the comments if any.

There are many online linters available, please check https://jsonlint.com/

link
suprjami 1251 days ago
Welcome to Microsoft, where standards and interoperability are a vague suggestion.
link