Hacker News new | ask | show | jobs
by lapcat 1254 days ago
> all the work happens in the public bug database. Code review, patch dev, etc for webkit occurs in bugzilla.

What about discussion?

Do you claim there is no private discussion among Apple engineers about WebKit bugs that have been put "InRadar"?

I see a lot of WebKit bugs that have no discussion whatsoever and just seem to arrive ex nihilo from Radar. You wonder what the reasoning or explanation is for a certain code change, and you'll find absolutely nothing about it in the Bugzilla.

2 comments

> Do you claim there is no private discussion among Apple engineers about WebKit bugs that have been put "InRadar"?

Open source bugs will have private/non-public conversations (whether it's in person, or on slack, or on a seperate issue tracker) all the time. That's not abnormal or all that damning.

> What about discussion?

Is achieved by talking among each other, or simply by knowing how to fix/implement the feature (not every bug requires any discussion at all). Either in person (which would be inherently "private" as you say), or irc historically - I'm unsure whether irc is still significant as I recall free node dying off or something a few years back?

> Do you claim there is no private discussion among Apple engineers about WebKit bugs that have been put "InRadar"?

No, I'm saying your claim that "The funny thing though is that Apple still sends WebKit bugs into Radar to work on them:" is nonsense. The reason that bugs are cloned to radar is so that they can be tracked for releases. I think you have decided that any time you don't see discussion in b.w.o it means discussion there must be discussion in radar, and that's false. The reality is that most bug fix/feature implementation doesn't require discussion during development, actual recorded discussion happens during review as that systematically results in recording the exchanges.

> I see a lot of WebKit bugs that have no discussion whatsoever and just seem to arrive ex nihilo from Radar.

Again, I think you grossly overestimate the amount of recorded "discussion" that goes with a bug.

> You wonder what the reasoning or explanation is for a certain code change, and you'll find absolutely nothing about it in the Bugzilla.

For many there's not anything in radar either, because many (most?) bugs you see are created to track reviewing the change, and don't exist before the review process. The lack of explanation is typically because the engineers working on changes have the context for why a change is needed, so don't include an explanation.

> I recall free node dying off or something a few years back?

Yeah, a kind of hostile takeover occurred, which the IRC community did not appreciate.

> Again, I think you grossly overestimate the amount of recorded "discussion" that goes with a bug.

Perhaps so. Seems a bit odd to me though. And a bit lonely :-)

> The lack of explanation is typically because the engineers working on changes have the context for why a change is needed, so don't include an explanation.

Well, I think it's worth noting that this is not very helpful to outsiders who are looking at and working with the code of an open source project.

Even in my closed source self owned projects, I like to provide useful context to my future self. ;-)

> Perhaps so. Seems a bit odd to me though. And a bit lonely :-)

People communicate in IRC (or a public slack now based on another comment?), in person, or in email. So when needed communication happens, it's just generally back and forth commentary in a bug is not a particularly good or efficient way to discuss implementation of bug fixes, features, etc.

> Well, I think it's worth noting that this is not very helpful to outsiders who are looking at and working with the code of an open source project.

Because it's a bug tracker being used to track bug fixes, not a tool for communicating with arbitrary people not involved in the project? I don't mean to be glib, but for WK at least that's just not what the bug trackers are used for.

> Even in my closed source self owned projects, I like to provide useful context to my future self.

In the bug report or in the code? Generally IME when code does things that are odd the explanation of that oddness is in the code (assuming not self explanatory) not the bug tracker.

It also depends on the bug itself, bug fixes you'd normally be able to see why a change was made (if not obvious from the title/description) is the attached test cases.

> So when needed communication happens, it's just generally back and forth commentary in a bug is not a particularly good or efficient way to discuss implementation of bug fixes, features, etc.

I disagree, because whether it's the intention or not ("it's a bug tracker being used to track bug fixes, not a tool for communicating with arbitrary people not involved in the project"), the bug report de facto becomes an important historical record for understanding the code. In the future, when someone looks back, the question that often comes to mind is "Why?" Why this (that)? Why now (then)? The motive, the historical context, is rarely something that becomes evident just looking at the code, even code with comments.

Can I change this code? Can I delete this code? How did this code ever work? You can't rely on unit tests to tell you the story behind the code. And when you come upon some "questionable" code, it's equally likely that the comments and/or tests are questionable too.

If the code was written to handle something publicly important, if debates were had, alternatives considered, choices made and rejected, that's worth knowing, in my opinion.

> The lack of explanation is typically because the engineers working on changes have the context for why a change is needed, so don't include an explanation.

Part of which is because the engineers are working on an unreleased feature that they’d like to put up “quietly”.