Hacker News new | ask | show | jobs
by biaxident 5286 days ago
Nice idea, but GitHub already has pull requests which work wonderfully for code reviews.

When I'm finished working on my branch I can submit a pull request. Everyone else on the team gets an email and can take a look at the new changes. We can have a conversation about the code and people can pull the branch and make their own changes. It's all very seamless and works great for remote teams.
1 comments
tseabrooks 5286 days ago
This highlights my only real complaint with github (Started out using Fogbugz / kiln [Hg])... Why does EVERYONE need to be notified?

This is counterproductive. We have 15 engineers and we all work on different submodules. When I issue a pull request (Or create a new issue) I would like to be able to select a subset of people to ping about it instead of announcing it to everyone. the current situation just creates a pile of messages 90% of which you don't care about so you have to filter them to find the ones that are relevant to you.

Along the same line I think it'd be nice to send something to a particular person that says, "Hey, YOU must review this and approve the pull request".

link