|
|
|
|
|
|
by dshpala
1283 days ago
|
|
|
What is "hard to deal with"? I definitely can be hard to deal with if you try to run BS by me. Things like unnecessary refactors for example really rub me the wrong way. I think that sometimes hard NO is the only right answer. "No, we don't need to do this, it's unnecessary, it can introduce bugs, and it wastes reviewers time. Not LGTM". I can see how this can be seen as "abrasive" and "hard to deal with". But sometimes swallowing your ego and abandoning a change is the right answer. |
|
|
I once got a PR review that said “doesn’t confirm to SOLID principles” Well, being self taught I didn’t know what the heck was he talking about, what part of my PR was he talking about or anything else! In the complete opposite side of the spectrum one of the most effective engineers I’ve meet (it was scary seeing how many story points he finished per sprint!) left comes more along the lines of “have you considered using a lambda function for this? It might make the code more readable and we wouldn’t need to go through the list 4 times. Here’s a way you could implement it: ~actual working rewrite of my function as a lambda function!~ Lmk if it doesn’t makes sense!”.
That teammate helped me grow more than anything else in that company, and the egregious mistakes I used to make, I only made them once!
So yeah, I think that there are occasions where NO is the only correct answer, but there are definitely multiple ways to say no.