|
|
|
|
|
|
by g051051
1300 days ago
|
|
|
> Company has lots of guidance Does this mean its an actual standard? You can fail the PR for not following standards. > Adding unit tests for some piece of logic Are unit tests required? Fail the PR if it doesn't have the tests. If you decide to allow a "I'll do it later", only do so if they have a ticket, assigned to them, in the backlog. > I discovered a chunk of code copied from Stackoverflow Now it's a problem for HR, because they're exposing the company to legal risk. All of these items are things that should be passed to the manager every time they happen. |
|
|