|
|
|
|
|
by haswell
1300 days ago
|
|
> If many of your discussions fall in this zone, it's possible you, yourself, may be taking guidelines as too black and white. I have very mixed feelings about this. On the one hand, I’m no fan of following process for the sake of it. On the other, the way to address policies that need an update is to sit down with the lead/manager and propose changes with evidence as to why. Deciding to just do things your way and then arguing about it is not the way. |
|
I worked at a place where 10k LoC PRs were the norm. At my next place, I’d open a 1k PR and people would lose their shit. They’d ask for it to be broken up into smaller PRs and my response was “it’s already ridiculously small”
Personally, I’d rather see the big PR and spend time reviewing that than trying to figure out what they’re trying to set up and do. As long as the big PR is coherent and well-written. If it’s spaghetti monster, I’ll pass.