Hacker News new | ask | show | jobs
by nomel 1304 days ago
As someone who has only experienced terrible code reviews, could you give a little summary of what you liked?
2 comments

Calling you out for lazy work. Teaching you how to use internal tools, company coding standards, suggesting better patterns, digging deep in to the context of system design and maintainability, suggesting other domain experts to tag in the reviews. I learned all sorts of Hack things that obviously I wouldn't learn outside from code reviews.
How are small things like "you left a commented out print/log" or "use color var not hex code" handled - or that a 'company coding standards' type thing. Are those types of things potentially automated with a linter or similar?
They probably had some pretty good cat meme image macros.
Yes good meme macros too. I left a few in my wake.