Hacker News new | ask | show | jobs
by mdaniel 1325 days ago
As best I can tell, there are exactly two comments in that file (I don't count the licensing and ahem CVS metadata), and neither of them add any enlightenment at all. Kernel development must be a very special culture. I tried finding the equivalent file in the Linux kernel, but while looking I saw there is at least one example of commentary to go along with a struct: https://sourcegraph.com/github.com/torvalds/linux/-/blob/dri...
1 comments
notaplumber1 1324 days ago
Apologies, I was pointing out the commit message itself rather than the contents of the commit, it's indeed full of magic numbers. It's reverse engineered, there are no docs from Qualcomm.

This is commit is plumbing work fixing GPIO support, which indirectly makes the keyboard work. I don't have any boot logs for the machine, but as I understand they have standard Microsoft-compatible HID keyboards/touchpads that work with OpenBSD's existing drivers.

https://man.openbsd.org/qcgpio

https://man.openbsd.org/qciic

link
mdaniel 1324 days ago
Yes, sorry, I wasn't directing the vile at you, that was just the first time I had seen a file from the OpenBSD kernel and was shocked at how aggressively opaque it was

And, to your point, if it was reverse engineered, that's more reason to comment, not less, because (a) memory is fleeting (b) if I wanted to contribute, I could read along about how Zen Master OpenBSD Reverser found those so I could go find more

link