|
|
|
|
|
by bborud
1323 days ago
|
|
Yeah, I think this is something that has to be solved by the tooling. It isn't reasonable to expect people to do a git blame and remember to email everyone whose code you want to change. That being said: I don't even expect people to notify me when changing code I have written at work. In fact, if people bothered me about code someone else should be perfectly capable of reviewing without me, I'd be a bit annoyed. I really don't need MORE interruptions. The fact that a breaking change was introduced is really an orthogonal issue. It isn't a given that the original authors would catch the problem. Maybe in this case they would, but I don't think this is a given. I have certainly experienced reviewing pull requests against code I have written only to let breaks slip by me. :-) To me this sounds more like the code didn't have sufficient tests to catch the breakage. If I had written the code I would probably have looked at improving the tests after helping fix the breakage so at least it doesn't happen again. But of course, that's just speculation since I don't know what was broken and how. |
|